refactor: consolidate MCP and dump trees, standardize util imports#11
Merged
Conversation
- Move all MCP code under `src/adapters/mcp/` (folder with `index.ts` + `build-server.ts`, `stringify.ts`, `to-json-schema.ts`, `transports.ts`, `__tests__/`), replacing the split between `src/adapters/mcp.ts` and `src/node/mcp/`. - Move dump code under `src/rpc/dump/` (`index.ts`, `error.ts`, `static.ts`, `__tests__/`), pulling `src/node/static-dump.ts` in alongside the rest. `collectStaticRpcDump` and `StaticRpcDump*` types now ship from `devframe/rpc` instead of `devframe/node`. - Replace relative `../utils/*` imports with `devframe/utils/*` across the package; add the convention to AGENTS.md. - Update build config (`tsdown.config.ts`, `alias.ts`, `tsconfig.base.json`) and error-doc source links to match the new paths.
✅ Deploy Preview for devfra ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/adapters/mcp/(one folder containingindex.tsplusbuild-server.ts,stringify.ts,to-json-schema.ts,transports.ts, and tests), replacing the prior split betweensrc/adapters/mcp.tsandsrc/node/mcp/.src/rpc/dump/(index.ts,error.ts,static.ts,__tests__/), pullingsrc/node/static-dump.tsin alongside the rest — socollectStaticRpcDumpand theStaticRpcDump*types now ship fromdevframe/rpcinstead ofdevframe/node.devframe/utils/*across the package (replacing 18 relative../utils/*paths) and document the convention inAGENTS.md. Build config (tsdown.config.ts,alias.ts,tsconfig.base.json) and error-doc source links updated to match.Test plan
pnpm lint— passespnpm typecheck— passespnpm test— 306 passed, including refreshed tsnapi snapshots reflecting the intentional./node→./rpcAPI surface shiftpnpm build— passes